Skip to content

Pass error callback function to auditing http filter.#606

Merged
Gerrit91 merged 7 commits intomasterfrom
send-correct-errors-in-auditing-filter
Feb 18, 2025
Merged

Pass error callback function to auditing http filter.#606
Gerrit91 merged 7 commits intomasterfrom
send-correct-errors-in-auditing-filter

Conversation

@Gerrit91
Copy link
Contributor

@Gerrit91 Gerrit91 commented Feb 3, 2025

Description

Depends on metal-stack/metal-lib#164.

Without this PR:

❯ k scale sts auditing-meili --replicas 0
statefulset.apps/auditing-meili scaled
❯ m network update internet-mini-lab --description "test"
Error: [POST /v1/network][500] updateNetwork default "{\"statuscode\":0,\"message\":\"\"}"

With this PR:

❯ k scale sts auditing-meili --replicas 0
statefulset.apps/auditing-meili scaled
❯ m network update internet-mini-lab --description "test"
Error: [POST /v1/network][500] updateNetwork default "{\"statuscode\":500,\"message\":\"MeilisearchCommunicationError unable to execute request (path \\\"GET /indexes/metal-2025-02-12\\\" with method \\\"FetchInfo\\\"): error when dialing 10.96.134.206:7700: dial tcp4 10.96.134.206:7700: connect: connection refused\"}"

@Gerrit91 Gerrit91 marked this pull request as ready for review February 17, 2025 14:28
@Gerrit91 Gerrit91 requested a review from a team as a code owner February 17, 2025 14:28
@Gerrit91 Gerrit91 requested review from mwennrich and removed request for mwennrich February 17, 2025 14:28
@Gerrit91 Gerrit91 merged commit 6d8b782 into master Feb 18, 2025
2 checks passed
@Gerrit91 Gerrit91 deleted the send-correct-errors-in-auditing-filter branch February 18, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants